[service] Start refactor of GetExporters #11249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
release:blocker
|
@djaglowski @dmitryax @tigrannajaryan this is pretty annoying to do for an interface we already want to remove. It would be nice to keep progress moving on #7370 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11249 +/- ##
=======================================
Coverage 91.41% 91.42%
=======================================
Files 424 424
Lines 20198 20187 -11
=======================================
- Hits 18465 18455 -10
+ Misses 1349 1348 -1
Partials 384 384 ☔ View full report in Codecov by Sentry. |
codeboten
approved these changes
Sep 23, 2024
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Sep 24, 2024
#### Description As part of open-telemetry#11204 I left `host`'s implementation of `GetExporters` alone, thinking I didn't need to change a deprecated interface implementation. But `GetExporters` depends on `component.DataType`, so we won't be able to remove `component.DataType` unless `GetExporters` is updated to use `pipeline.Signal` instead. This PR deprecates the deprecated `GetExporters` interface with `GetExportersWithSignal`, which uses `pipeline.Signal`. Then we'll follow the process to rename `GetExportersWithSignal` back to `GetExporters`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #11204 I left
host's implementation ofGetExportersalone, thinking I didn't need to change a deprecated interface implementation.But
GetExportersdepends oncomponent.DataType, so we won't be able to removecomponent.DataTypeunlessGetExportersis updated to usepipeline.Signalinstead.This PR deprecates the deprecated
GetExportersinterface withGetExportersWithSignal, which usespipeline.Signal. Then we'll follow the process to renameGetExportersWithSignalback toGetExporters.