Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] docs(builder): fix link to releases page #11260

Merged

Conversation

andrzej-stencel
Copy link
Member

The location of builder binary releases has changed since v0.107.0.

https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md#-enhancements--3

ocb: migrate build and release of ocb binaries to opentelemetry-collector-releases repository (#10710) ocb binaries will now be released under open-telemetry/opentelemetry-collector-releases tagged as "cmd/builder/vX.XXX.X"

The location of builder binary releases has changed since v0.107.0.

https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md#-enhancements--3

> `ocb`: migrate build and release of ocb binaries to opentelemetry-collector-releases repository (open-telemetry#10710) ocb binaries will now be released under open-telemetry/opentelemetry-collector-releases tagged as "cmd/builder/vX.XXX.X"
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d6f568d). Learn more about missing BASE report.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11260   +/-   ##
=======================================
  Coverage        ?   91.42%           
=======================================
  Files           ?      424           
  Lines           ?    20187           
  Branches        ?        0           
=======================================
  Hits            ?    18455           
  Misses          ?     1348           
  Partials        ?      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@songy23
Copy link
Member

songy23 commented Sep 24, 2024

This is already covered in https://github.com/open-telemetry/opentelemetry-collector/pull/11234/files, though I'm good with merging this small change first.

@bogdandrutu bogdandrutu merged commit 4709346 into open-telemetry:main Sep 24, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 24, 2024
@andrzej-stencel andrzej-stencel deleted the fix-builder-releases-link branch September 25, 2024 09:44
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024
The location of builder binary releases has changed since v0.107.0.


https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md#-enhancements--3

> `ocb`: migrate build and release of ocb binaries to
opentelemetry-collector-releases repository (open-telemetry#10710) ocb binaries will
now be released under open-telemetry/opentelemetry-collector-releases
tagged as "cmd/builder/vX.XXX.X"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants