[chore] Move back processor definitions, make profile embed processor #11286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
added
the
release:blocker
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11286 +/- ##
==========================================
- Coverage 91.52% 91.48% -0.05%
==========================================
Files 424 423 -1
Lines 20222 20239 +17
==========================================
+ Hits 18509 18516 +7
- Misses 1329 1339 +10
Partials 384 384 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
move-back-processor
branch
from
773415f
to
ee1ce1b
Compare
dmitryax
reviewed
Sep 27, 2024
| processor.WithLogs(createProcessorLogs, component.StabilityLevelDeprecated), | ||
| processorprofiles.WithTraces(createProcessorTraces, component.StabilityLevelDevelopment), | ||
| processorprofiles.WithMetrics(createProcessorMetrics, component.StabilityLevelAlpha), | ||
| processorprofiles.WithLogs(createProcessorLogs, component.StabilityLevelDeprecated), |
There was a problem hiding this comment.
I think we should rename processorprofiles to something like expprocessor without waiting for another new signal
There was a problem hiding this comment.
Can do that later, since is experimental.
dmitryax
approved these changes
Sep 27, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
…open-telemetry#11286) Same as open-telemetry#11254 but for processor Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #11254 but for processor