Go1.23 timers #11334
Open
Go1.23 timers #11334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11334 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 430 431 +1
Lines 20226 20226
=======================================
Hits 18509 18509
Misses 1342 1342
Partials 375 375 ☔ View full report in Codecov by Sentry. |
codeboten
reviewed
Oct 2, 2024
| package batchprocessor // import "go.opentelemetry.io/collector/processor/batchprocessor" | ||
|
|
||
| func (b *shard) stopTimer() { | ||
| if b.hasTimer() { |
There was a problem hiding this comment.
Is it possible to add a test to capture the regression this is fixing?
codeboten
reviewed
Oct 2, 2024
Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking issue
Fixes #11332
Testing
Documentation