Use slices of pointers in pprofile #11339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ended up turning all of them from values to pointers, as each of them looks like it could be big (link may be the only grey one). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11339 +/- ##
==========================================
+ Coverage 91.51% 91.54% +0.03%
==========================================
Files 430 428 -2
Lines 20226 20230 +4
==========================================
+ Hits 18509 18519 +10
+ Misses 1342 1337 -5
+ Partials 375 374 -1 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Oct 3, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description All these slices of values have a potential to store large amounts of data, and should therefore be slices of pointers. <!-- Issue number if applicable --> #### Link to tracking issue Fixes open-telemetry#11281 cc @mx-psi @bogdandrutu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All these slices of values have a potential to store large amounts of data, and should therefore be slices of pointers.
Link to tracking issue
Fixes #11281
cc @mx-psi @bogdandrutu