Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage of mdatagen #11352

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Improve coverage of mdatagen #11352

merged 4 commits into from
Oct 9, 2024

Conversation

narcis96
Copy link
Contributor

@narcis96 narcis96 commented Oct 4, 2024 •
edited
Loading

Bump coverage of cmd/mdatagen/internal/command.go from 70.40% to 79.37%

Fixes #11219

@narcis96 narcis96 requested a review from a team as a code owner October 4, 2024 06:30
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 4, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@narcis96 narcis96 mentioned this pull request Oct 4, 2024
Closed
@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 4, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.17%. Comparing base (151f837) to head (240f8f8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mdatagen/internal/command.go 57.14% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11352      +/-   ##
==========================================
+ Coverage   92.07%   92.17%   +0.10%     
==========================================
  Files         432      432              
  Lines       20299    20301       +2     
==========================================
+ Hits        18690    18713      +23     
+ Misses       1249     1226      -23     
- Partials      360      362       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codeboten
codeboten approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @narcis96

@codeboten codeboten merged commit 83b18b1 into open-telemetry:main Oct 9, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 9, 2024
@narcis96 narcis96 deleted the narcis/mdatagen_tests branch October 15, 2024 07:13
@narcis96 narcis96 mentioned this pull request Oct 21, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.112.0
Development

Successfully merging this pull request may close these issues.

Add more coverage to mdatagen
3 participants
@narcis96 @codeboten @songy23