Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #11351 #11358

Closed
wants to merge 2 commits into from
Closed

Fix for #11351 #11358

wants to merge 2 commits into from

Conversation

shivanthzen
Copy link

Description

Link to tracking issue

Fixes #11351

Testing

Documentation

@shivanthzen shivanthzen requested a review from a team as a code owner October 4, 2024 11:27
@djaglowski
Copy link
Member

Thanks for working on this @shivanthzen. While I agree this fixes the issue, we need to be very deliberate about the metrics we add.

In this case, we have previously discussed adding an outcome attribute to the outgoing metric, which would serve nearly the same purpose as the new metric you've suggested.

However, I think we should make a quick fix where the outgoing value is reported as 0 if there is an error.

@djaglowski
Copy link
Member

I've opened #11360 with the solution I described

@shivanthzen
Copy link
Author

Makes sense, thanks 👍

@shivanthzen shivanthzen closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processor In/Out metrics not recorded if process func fails (even for skipping next component)
2 participants