[exporter] exporter queue Read() #11396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11396 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 432 432
Lines 20297 20296 -1
=======================================
Hits 18702 18702
+ Misses 1232 1231 -1
Partials 363 363 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
Oct 8, 2024
sfc-gh-sili
force-pushed
the
sili-queue-batcher-read
branch
5 times, most recently
from
5834f7a
to
95adb3d
Compare
sfc-gh-sili
changed the title
bogdandrutu
reviewed
Oct 9, 2024
dmitryax
reviewed
Oct 9, 2024
sfc-gh-sili
force-pushed
the
sili-queue-batcher-read
branch
2 times, most recently
from
4d78360
to
3a42e45
Compare
bogdandrutu
reviewed
Oct 10, 2024
bogdandrutu
approved these changes
Oct 10, 2024
sfc-gh-sili
force-pushed
the
sili-queue-batcher-read
branch
from
7217432
to
bfee648
Compare
dmitryax
approved these changes
Oct 10, 2024
sfc-gh-sili
force-pushed
the
sili-queue-batcher-read
branch
from
bfee648
to
145d901
Compare
bogdandrutu
approved these changes
Oct 11, 2024
Comment on lines
+47
to
+48
| consumeErr := qc.consumeFunc(ctx, req) | ||
| qc.queue.OnProcessingFinished(index, consumeErr) |
There was a problem hiding this comment.
Suggested change
| consumeErr := qc.consumeFunc(ctx, req) | |
| qc.queue.OnProcessingFinished(index, consumeErr) | |
| qc.queue.OnProcessingFinished(index, qc.consumeFunc(ctx, req)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a public function
GetNextItemto queue (both persistent queue and bounded memory queue)Why this change?
Instead of blocking until consumption of the item is done, we would like to separate the API for reading and committing consumption.
Before:
Consume(consumeFunc)After:
idx, item = Read()OnProcessingFinished(idx)Link to tracking issue
#8122
#10368
Testing
Documentation