Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update cmd/builder documentation for docker image release #11480

Merged

Conversation

jackgopack4
Copy link
Contributor

@jackgopack4 jackgopack4 commented Oct 17, 2024

since open-telemetry/opentelemetry-collector-releases#671 was merged into releases repository, docker images will be published starting with ocb version 0.112.0

This reverts commit 8c4cfe5.

Description

update documentation for cmd/builder to include docker release information

Link to tracking issue

Relates to #5712
Documentation for open-telemetry/opentelemetry-collector-releases#671

Testing

n/a

Documentation

README.md and release.md

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (f2b31d1) to head (50174b3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11480   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         433      433           
  Lines       23617    23617           
=======================================
  Hits        21607    21607           
  Misses       1642     1642           
  Partials      368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgopack4 jackgopack4 changed the title update cmd/builder documentation for docker image release [chore] update cmd/builder documentation for docker image release Oct 17, 2024
@jackgopack4 jackgopack4 marked this pull request as ready for review October 21, 2024 14:48
@jackgopack4 jackgopack4 requested a review from a team as a code owner October 21, 2024 14:48
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review the docs for accuracy at this point, but I will be going through the release today with these steps, so I'm approving this with the expectation that I can modify it post-release if any part of the docs need updating.

@jackgopack4
Copy link
Contributor Author

there was an additional section about an "Update Version" github workflow for the releases repo that is still under discussion (open-telemetry/opentelemetry-collector-releases#684) so I removed those bits with 50174b3 (#11480)

@mx-psi mx-psi merged commit 035fa2b into open-telemetry:main Oct 21, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants