Rename host metrics to more consistent names based on OTEP #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-bebbington
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia and
tigrannajaryan
as code owners
james-bebbington
commented
Jul 4, 2020
| descriptor.SetDescription("Time spent in disk operations.") | ||
| descriptor.SetUnit("ms") | ||
| descriptor.SetType(pdata.MetricTypeInt64) | ||
| descriptor.SetType(pdata.MetricTypeMonotonicInt64) |
There was a problem hiding this comment.
This was incorrectly a gauge, when it should have been a counter
…rged otep, and update function names accordingly
james-bebbington
force-pushed
the
hostmetrics-rename-metadata
branch
from
13e0c8e
to
f784695
Compare
Codecov Report
@@ Coverage Diff @@
## master #1261 +/- ##
==========================================
+ Coverage 88.60% 88.61% +0.01%
==========================================
Files 207 207
Lines 15110 15110
==========================================
+ Hits 13388 13390 +2
+ Misses 1288 1287 -1
+ Partials 434 433 -1
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Jul 7, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
…rged otep, and update function names accordingly (open-telemetry#1261)
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Update the internal global TextMapPropagator Include feedback from a post-merge review of open-telemetry#1258 * Apply feedback * Update api/global/internal/propagator.go Co-authored-by: Steven E. Harris <[email protected]> Co-authored-by: Steven E. Harris <[email protected]>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
…ead of CURLOPT_TIMEOUT (open-telemetry#1261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming metrics based on open-telemetry/oteps#119
These may change again, but want to at least get closer to what we are likely to standardise on. Also renamed related functions & made the function names more consistent.
There are lots of files touched, but no functionality changes. Only constants, variables, functions, & files renamed.
(I will also rename
virtualmemoryscrapertoswapscraperin the next PR)