Add Prometheus Remote Write Exporter supporting Cortex - Metrics exporter #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyan0
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1525 +/- ##
==========================================
+ Coverage 91.42% 91.52% +0.09%
==========================================
Files 248 251 +3
Lines 17219 17524 +305
==========================================
+ Hits 15743 16039 +296
- Misses 1064 1069 +5
- Partials 412 416 +4
Continue to review full report at Codecov.
|
…for service package
This was referenced Aug 12, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Ignore k8sclusterreceiver for update-deps * Ensure all deps are updated * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of PRs implementing a Prometheus remote write exporter supporting Cortex. See related PR #1524
Description: This PR adds the metric exporter for Prometheus remote write integrated backends, such as Cortex. The exporter drops non-cumulative monotonic, histogram, and summary OTLP metrics.
Please note this metrics exporter does not support Prometheus default labels such as
joborinstancelabels. An issue addressing Prometheus default labels will be filed later. Another related feature is to derive labels from a Resource. This functionality already exists in the Go SDK and will be implemented in another PR. This feature could allow users to specify which attributes they want to add as labels.Link to tracking Issue: #1150
Related issues are:
Metrics aggregation proposal: #1422
Prometheus exporter not functional: #1255
Related spec discussion: #731
Testing:
Currently unit tests have 96% code coverage. There are tests using HTTP Servers as mock backends. We will be adding end-to-end tests and pipeline testing with Cortex. Tests with a collector sending to a Cortex instance running locally has also been done.
We request the community to provide suggestions and links for existing testing environments you may be aware of. Some questions we have include how to setup a complete pipeline with a Cortex gateway.
cc: @annanay25 @gouthamve Would be great to get expert feedback from you :-)
Documentation:
readme.md with sample configuration, file structure, and assumptions
Design documentation: PR Add Cortex and Prometheus Remote Write exporter design #1464
cc: @huyan0 @danielbang907 @alolita @markcartertm @sonofachamp @morigs
Request for review: @jmacd @bogdandrutu @annanay25 @gouthamve @open-telemetry/collector-approvers @open-telemetry/collector-maintainers