Add Prometheus Remote Write Exporter supporting Cortex - conversion and export for Summary OTLP metrics #1649
Conversation
huyan0
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
+ Coverage 92.24% 92.25% +0.01%
==========================================
Files 262 262
Lines 18765 18843 +78
==========================================
+ Hits 17309 17383 +74
- Misses 1042 1046 +4
Partials 414 414
Continue to review full report at Codecov.
|
huyan0
force-pushed
the
summary_exporter
branch
from
57d2e1f
to
18883d1
Compare
|
Unfortunately this will have to wait couple of weeks until summary support is added back to the metrics internal pipeline |
|
I am sorry that you cannot finish this in time for your internship but we had to make this decision in order to make progress on the protocol |
Not a problem and understood. Really appreciate all the reviews and help from you! |
|
Closing this for the moment, when Summary will be supported will reopen or reuse the code |
Fixed some warnings reported by clang. -Wnewline-eof no newline at end of file -Wc++98-compat-extra-semi extra ';' outside of a function is incompatible with C++98 -Winconsistent-missing-destructor-override '~XXX' overrides a destructor but is not marked 'override' -Wheader-hygiene using namespace directive in global context in header -Wunused-parameter unused parameter Fixed some warnings reported by gcc. -Werror=missing-field-initializers missing initializer for member ‘opentelemetry::v1::sdk::trace::SamplingResult::trace_state’ -Werror=unused-variable unused variable -Werror=unused-parameter unused parameter
This PR is part of a series of PRs implementing a Prometheus remote write exporter supporting Cortex.
**See related PR #1577, PR #1643 **
Description: This PR adds export support for summary metrics for Prometheus remote write integrated backends, such as Cortex. The exporter drops non-cumulative monotonic, histogram, and summary OTLP metrics.
Please note this metrics exporter does not support Prometheus default labels such as
joborinstancelabels. An issue addressing Prometheus default labels will be filed later. Another related feature is to derive labels from a Resource. This functionality already exists in the Go SDK and will be implemented in another PR. This feature could allow users to specify which attributes they want to add as labels.Link to tracking Issue: #1150
Related issues are:
Metrics aggregation proposal: #1422
Prometheus exporter not functional: #1255
Related spec discussion: #731
Documentation:
readme.md with sample configuration, file structure, and assumptions
Design documentation: PR Add Cortex and Prometheus Remote Write exporter design #1464
cc: @huyan0 @alolita @jmacd @bogdandrutu