Return proto status for OTLP receiver when failed #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
bogdandrutu
force-pushed
the
returnproto
branch
from
f248b23
to
d9e0d7c
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
returnproto
branch
from
d9e0d7c
to
c7e8385
Compare
Codecov Report
@@ Coverage Diff @@
## master #1788 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 262 262
Lines 18602 18603 +1
=======================================
+ Hits 17051 17052 +1
Misses 1118 1118
Partials 433 433
Continue to review full report at Codecov.
|
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* WIP: OS and Process resource detectors * Completed documentation headers * Added empty test files for OS and Process resource functions * Split long line * Added resource.WithOS function test * Added resource.WithProcess* functions tests * Renamed osDetector and WithOS function to better reflect they only add the os.type attribute * Updated changelog * WIP: possible use of wrappers for getting attribute values * Refined implementation of wrapper functions providing os/runtime/user information * Added PR number to new changelog entries Co-authored-by: Tyler Yahn <[email protected]> * Fix wrong function name in documentation header Co-authored-by: Tyler Yahn <[email protected]> * Fixed wording in WithProcessOwner documentation header Co-authored-by: Tyler Yahn <[email protected]> * Updated osTypeDetector * Replaced ToUpper with ToLower to match the current convention. * Used runtimeOS provider to get the OS name. * Adapted WithOSType test to mock runtime providers Co-authored-by: Tyler Yahn <[email protected]>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…pen-telemetry#1788) * Bump github.com/signalfx/signalfx-go from 1.21.0 to 1.22.0 in /tests Bumps [github.com/signalfx/signalfx-go](https://github.com/signalfx/signalfx-go) from 1.21.0 to 1.22.0. - [Release notes](https://github.com/signalfx/signalfx-go/releases) - [Changelog](https://github.com/signalfx/signalfx-go/blob/master/CHANGELOG.md) - [Commits](signalfx/signalfx-go@v1.21.0...v1.22.0) --- updated-dependencies: - dependency-name: github.com/signalfx/signalfx-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * go mod tidy Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jeffreyc-splunk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1357