Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose telemetry level in the configtelemetry #1796

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Sep 16, 2020

Next PR will add a config setting that can be embedded in every component config.

Signed-off-by: Bogdan Drutu [email protected]

Updates #1663
Updates #1413

@bogdandrutu bogdandrutu changed the title Expose telemetry level in the components Expose telemetry level in the configtelemetry Sep 16, 2020
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Next PR will add a config setting that can be embedded in every component config.

Signed-off-by: Bogdan Drutu <[email protected]>
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1796 into master will not change coverage.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1796   +/-   ##
=======================================
  Coverage   91.10%   91.10%           
=======================================
  Files         263      263           
  Lines       16107    16107           
=======================================
  Hits        14675    14675           
  Misses       1004     1004           
  Partials      428      428           
Impacted Files Coverage Δ
processor/queuedprocessor/metrics.go 76.47% <0.00%> (ø)
...samplingprocessor/tailsamplingprocessor/metrics.go 96.66% <0.00%> (ø)
internal/collector/telemetry/telemetry.go 86.00% <60.00%> (ø)
processor/batchprocessor/batch_processor.go 98.01% <100.00%> (ø)
processor/batchprocessor/metrics.go 100.00% <100.00%> (ø)
processor/metrics.go 71.76% <100.00%> (ø)
receiver/fluentforwardreceiver/observ/metrics.go 100.00% <100.00%> (ø)
service/telemetry.go 81.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1c189...6391166. Read the comment docs.

@bogdandrutu bogdandrutu merged commit e7e6693 into open-telemetry:master Sep 18, 2020
@bogdandrutu bogdandrutu deleted the exposetellevel branch September 18, 2020 23:11
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…n-telemetry#1796)

* docs: update InstallNewPipeline example comment

* docs: update changelog after PR submit

* fix: wrap issue number in parens

* docs: use test example to document prometheus.InstallNewPipeline

* fix: update CHANGELOG to reflect PR state

Co-authored-by: Tyler Yahn <[email protected]>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants