Remove SetType from configmodels, ensure all registered factories set the type in config. #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
… the type Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
settype
branch
from
d3fe54e
to
db7fdb9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1798 +/- ##
=======================================
Coverage 91.95% 91.96%
=======================================
Files 263 263
Lines 18817 18809 -8
=======================================
- Hits 17303 17297 -6
+ Misses 1083 1082 -1
+ Partials 431 430 -1
Continue to review full report at Codecov.
|
dmitryax
approved these changes
Sep 16, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Change NewSplitDriver paramater and initialization * Update CHANGELOG.md Co-authored-by: Anthony Mirabella <[email protected]> * Update CHANGELOG.md Co-authored-by: Anthony Mirabella <[email protected]> * Update exporters/otlp/protocoldriver.go Co-authored-by: Anthony Mirabella <[email protected]> * Update exporters/otlp/protocoldriver.go Co-authored-by: Anthony Mirabella <[email protected]> * Update exporters/otlp/protocoldriver.go Co-authored-by: Anthony Mirabella <[email protected]> * Update exporters/otlp/protocoldriver.go Co-authored-by: Anthony Mirabella <[email protected]> * Move splitdriver option into options.go and rename * Update CHANGELOG.md Co-authored-by: Anthony Mirabella <[email protected]> * Change option name and nil test to snapshots * Update exporters/otlp/protocoldriver.go Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/protocoldriver.go Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/protocoldriver.go Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/protocoldriver.go Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/options.go Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/options.go Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/options.go Co-authored-by: Tyler Yahn <[email protected]> * Update exporters/otlp/options.go Co-authored-by: Tyler Yahn <[email protected]> * Change SplitDriverOption to match spec * Update changelog entry Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.