Add SpanID data type #1855
Merged
Add SpanID data type #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais and
pjanotti
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
- Coverage 91.27% 91.25% -0.02%
==========================================
Files 274 274
Lines 16392 16392
==========================================
- Hits 14961 14959 -2
- Misses 1001 1002 +1
- Partials 430 431 +1
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Sep 28, 2020
This is step 2 in adding SpanID custom data type. This only introduces the type but does not yet use it in Protobuf messages. It will added in a future PR. Contributes to open-telemetry#1177
tigrannajaryan
force-pushed
the
feature/tigran/custom-spanid2
branch
from
af57a27
to
a60f8a6
Compare
|
@bogdandrutu Rebased, PTAL. |
bogdandrutu
approved these changes
Sep 29, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* remove Set.Encoded(Encoder) enconding cache Co-authored-by: Tyler Yahn <[email protected]>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step 2 in adding SpanID custom data type. This only introduces the
type but does not yet use it in Protobuf messages. It will added in a future PR.
Contributes to #1177