Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2c/3 Update hostmetrics swap scraper to use new perfcounters package #1869

Merged

Conversation

james-bebbington
Copy link
Member

Link to tracking Issue: #973

Description:
 1. Add new perflib package
 2. Migrate host metrics scrapers to use new package
 3. Remove third_party PDH code

Depends on #1835

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #1869 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1869      +/-   ##
==========================================
+ Coverage   91.23%   91.29%   +0.06%     
==========================================
  Files         272      272              
  Lines       16263    16263              
==========================================
+ Hits        14838    14848      +10     
+ Misses        998      990       -8     
+ Partials      427      425       -2     
Impacted Files Coverage Δ
...mplingprocessor/tailsamplingprocessor/processor.go 75.00% <0.00%> (+0.96%) ⬆️
translator/internaldata/resource_to_oc.go 89.36% <0.00%> (+2.12%) ⬆️
...ssor/tailsamplingprocessor/idbatcher/id_batcher.go 100.00% <0.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a45ae9...e070a84. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 5d723ab into open-telemetry:master Sep 28, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Add Markdown link check

* Add replacement for registry URL and clean ignored

* Fix config file name

* Update .markdown-link.json

Co-authored-by: Anthony Mirabella <[email protected]>

Co-authored-by: Anthony Mirabella <[email protected]>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants