Log Support in Attribute Processor (2/2) #1934
Conversation
zeitlinger
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1934 +/- ##
==========================================
+ Coverage 91.49% 91.53% +0.03%
==========================================
Files 282 283 +1
Lines 16631 16679 +48
==========================================
+ Hits 15217 15267 +50
+ Misses 978 975 -3
- Partials 436 437 +1
Continue to review full report at Codecov.
|
|
@zeitlinger can you please rebase from master so that changes from 1830 are not visible here? |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This complements the trace span support already present. It shares the same config struct to maintain backwards-compatibility with spans in the cleanest way possible.
zeitlinger
force-pushed
the
log-attribute-proc-pt2
branch
from
31abb97
to
c694b9c
Compare
|
@tigrannajaryan rebase done |
|
@zeitlinger Can you please split the PR into 2 parts: the refactoring of the common tests for spans and logs and addition of logs support to attributes processor. This PR is big and difficult to follow because it moves large volumes of code between files and it is hard to see what is changed in the behavior. |
@tigrannajaryan done - test refactoring is moved to #1997 |
zeitlinger
force-pushed
the
log-attribute-proc-pt2
branch
from
c694b9c
to
dd38108
Compare
zeitlinger
force-pushed
the
log-attribute-proc-pt2
branch
from
dd38108
to
37dc5d2
Compare
There was a problem hiding this comment.
Thank you @zeitlinger ! Nice PR and highly wanted feature addition.
processor/spanprocessor/span.go
Outdated
| @@ -47,6 +47,7 @@ func newSpanProcessor(config Config) (*spanProcessor, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Nit: delete unneeded change.
| rss := td.ResourceSpans() | ||
| for i := 0; i < rss.Len(); i++ { | ||
| rs := rss.At(i) | ||
| if rs.IsNil() { | ||
| continue | ||
| } | ||
| resource := rs.Resource() | ||
| ilss := rss.At(i).InstrumentationLibrarySpans() | ||
| ilss := rs.InstrumentationLibrarySpans() |
There was a problem hiding this comment.
👍 for attention to details.
* Release v0.59.0
Contains merge for #1830
extract common tests from span and log filtering