Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user agent header to outgoing prometheus remote write exporter http request #2000

Conversation

amanbrar1999
Copy link
Contributor

@amanbrar1999 amanbrar1999 commented Oct 22, 2020

Description:
Added User-Agent header to Prometheus Remote Write Exporter's outgoing http request. This allows endpoints to identify whether an incoming metric has come from an OTel Collector instance.

Testing:
Unit tests added conforming with existing tests to check headers.

Documentation:
No documentation has been added as it is for internal usage rather than customer usage.

Note: I am assuming here that the VERSION variable in the makefile will be set when we reach GA, as currently it is not and the version in the version package is just the default value of "latest"

-- cc @alolita

@amanbrar1999 amanbrar1999 requested a review from a team October 22, 2020 18:50
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #2000 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2000      +/-   ##
==========================================
- Coverage   91.51%   91.49%   -0.03%     
==========================================
  Files         282      282              
  Lines       16623    16624       +1     
==========================================
- Hits        15213    15210       -3     
- Misses        976      978       +2     
- Partials      434      436       +2     
Impacted Files Coverage Δ
exporter/prometheusremotewriteexporter/exporter.go 91.66% <100.00%> (+0.07%) ⬆️
translator/internaldata/resource_to_oc.go 89.04% <0.00%> (-5.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec36a15...2cab2a7. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuraaga is this ok?

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this since wasn't assigned - sorry about that!

@tigrannajaryan tigrannajaryan merged commit 7ddd242 into open-telemetry:master Oct 29, 2020
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…open-telemetry#2000)

Bumps [github.com/hashicorp/vault-plugin-auth-gcp](https://github.com/hashicorp/vault-plugin-auth-gcp) from 0.13.2 to 0.14.0.
- [Release notes](https://github.com/hashicorp/vault-plugin-auth-gcp/releases)
- [Changelog](https://github.com/hashicorp/vault-plugin-auth-gcp/blob/main/CHANGELOG.md)
- [Commits](hashicorp/vault-plugin-auth-gcp@v0.13.2...v0.14.0)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/vault-plugin-auth-gcp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants