-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user agent header to outgoing prometheus remote write exporter http request #2000
Add user agent header to outgoing prometheus remote write exporter http request #2000
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2000 +/- ##
==========================================
- Coverage 91.51% 91.49% -0.03%
==========================================
Files 282 282
Lines 16623 16624 +1
==========================================
- Hits 15213 15210 -3
- Misses 976 978 +2
- Partials 434 436 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anuraaga is this ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this since wasn't assigned - sorry about that!
…open-telemetry#2000) Bumps [github.com/hashicorp/vault-plugin-auth-gcp](https://github.com/hashicorp/vault-plugin-auth-gcp) from 0.13.2 to 0.14.0. - [Release notes](https://github.com/hashicorp/vault-plugin-auth-gcp/releases) - [Changelog](https://github.com/hashicorp/vault-plugin-auth-gcp/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault-plugin-auth-gcp@v0.13.2...v0.14.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault-plugin-auth-gcp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description:
Added User-Agent header to Prometheus Remote Write Exporter's outgoing http request. This allows endpoints to identify whether an incoming metric has come from an OTel Collector instance.
Testing:
Unit tests added conforming with existing tests to check headers.
Documentation:
No documentation has been added as it is for internal usage rather than customer usage.
Note: I am assuming here that the
VERSION
variable in the makefile will be set when we reach GA, as currently it is not and the version in the version package is just the default value of "latest"-- cc @alolita