-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tailsamplingprocessor #2012
Merged
bogdandrutu
merged 1 commit into
open-telemetry:master
from
jpkrohling:jpkrohling/2020-remove-tail-based-sampling
Oct 27, 2020
Merged
Remove tailsamplingprocessor #2012
bogdandrutu
merged 1 commit into
open-telemetry:master
from
jpkrohling:jpkrohling/2020-remove-tail-based-sampling
Oct 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
force-pushed
the
jpkrohling/2020-remove-tail-based-sampling
branch
from
October 27, 2020 11:03
c66a586
to
1242afa
Compare
jpkrohling
force-pushed
the
jpkrohling/2020-remove-tail-based-sampling
branch
from
October 27, 2020 11:31
1242afa
to
83872bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2012 +/- ##
==========================================
+ Coverage 91.67% 91.91% +0.23%
==========================================
Files 284 276 -8
Lines 16883 16466 -417
==========================================
- Hits 15477 15134 -343
+ Misses 972 919 -53
+ Partials 434 413 -21
Continue to review full report at Codecov.
|
jpkrohling
force-pushed
the
jpkrohling/2020-remove-tail-based-sampling
branch
from
October 27, 2020 19:54
83872bc
to
0be5ada
Compare
The contrib-test is failing for reasons unrelated to this PR:
|
**Description:** as discussed in the past, we are moving the tail-based sampling processor to the contrib repository. IMPORTANT: there shouldn't be a release of the collector/contrib until the contrib counterpart is merged! **Link to tracking Issue:** Partially addresses open-telemetry#2020. **Testing:** regular test. **Documentation:** Removed processor from readme. Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
jpkrohling/2020-remove-tail-based-sampling
branch
from
October 27, 2020 20:06
0be5ada
to
53ad3ab
Compare
bogdandrutu
approved these changes
Oct 27, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* Interface stability documentation * Update versioning policy * Update CONTRIBUTING * Document how to extend immutable interfaces * Markdown format VERSIONING changes
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…m/testcontainers/testcontainers-go to v0.13.0. Fix breaking changes for these version bumps. (open-telemetry#2012)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: as discussed in the past, we are moving the tail-based sampling processor to the contrib repository.
IMPORTANT: there shouldn't be a release of the collector/contrib until the contrib counterpart is merged!
Link to tracking Issue: Partially addresses #2010.
Testing: regular test.
Documentation: Removed processor from readme.
Signed-off-by: Juraci Paixão Kröhling [email protected]