Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tailsamplingprocessor #2012

Conversation

jpkrohling
Copy link
Member

@jpkrohling jpkrohling commented Oct 27, 2020

Description: as discussed in the past, we are moving the tail-based sampling processor to the contrib repository.

IMPORTANT: there shouldn't be a release of the collector/contrib until the contrib counterpart is merged!

Link to tracking Issue: Partially addresses #2010.

Testing: regular test.

Documentation: Removed processor from readme.

Signed-off-by: Juraci Paixão Kröhling [email protected]

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #2012 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2012      +/-   ##
==========================================
+ Coverage   91.67%   91.91%   +0.23%     
==========================================
  Files         284      276       -8     
  Lines       16883    16466     -417     
==========================================
- Hits        15477    15134     -343     
+ Misses        972      919      -53     
+ Partials      434      413      -21     
Impacted Files Coverage Δ
service/defaultcomponents/defaults.go 84.90% <ø> (-0.28%) ⬇️
service/telemetry.go 81.66% <ø> (-0.31%) ⬇️
translator/internaldata/resource_to_oc.go 94.52% <0.00%> (+5.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b1122...53ad3ab. Read the comment docs.

@jpkrohling jpkrohling force-pushed the jpkrohling/2020-remove-tail-based-sampling branch from 83872bc to 0be5ada Compare October 27, 2020 19:54
@jpkrohling
Copy link
Member Author

The contrib-test is failing for reasons unrelated to this PR:

translator/cause.go:144:62: cannot use newSegmentID().Bytes() (type [8]byte) as type []byte in argument to hex.EncodeToString

**Description:** as discussed in the past, we are moving the tail-based sampling processor to the contrib repository.

IMPORTANT: there shouldn't be a release of the collector/contrib until the contrib counterpart is merged!

**Link to tracking Issue:** Partially addresses open-telemetry#2020.

**Testing:** regular test.

**Documentation:** Removed processor from readme.

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling force-pushed the jpkrohling/2020-remove-tail-based-sampling branch from 0be5ada to 53ad3ab Compare October 27, 2020 20:06
@bogdandrutu bogdandrutu merged commit 6ae6615 into open-telemetry:master Oct 27, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Interface stability documentation

* Update versioning policy

* Update CONTRIBUTING

* Document how to extend immutable interfaces

* Markdown format VERSIONING changes
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…m/testcontainers/testcontainers-go to v0.13.0. Fix breaking changes for these version bumps. (open-telemetry#2012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants