Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark as deprecated NewAttributeValue #2022

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

bogdandrutu
Copy link
Member

Remove usages from non generated call. It is strange to have two new functions that do the same thing.

Remove usages from non generated call. It is strange to have two new functions that do the same thing.

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu requested a review from a team October 28, 2020 07:47
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #2022 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2022   +/-   ##
=======================================
  Coverage   91.88%   91.88%           
=======================================
  Files         276      276           
  Lines       16495    16495           
=======================================
  Hits        15157    15157           
  Misses        922      922           
  Partials      416      416           
Impacted Files Coverage Δ
consumer/pdata/common.go 96.68% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14618bd...008a532. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 371514c into open-telemetry:master Oct 28, 2020
@bogdandrutu bogdandrutu deleted the deprecatenatv branch October 28, 2020 23:41
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* add HTTP support for OTLP metrics exporter

* add to changelog

* fix unit test not covered before

* add otlpmetrichttp module to .github/dependabot.yml

* add test file for client.go

* run make commit to clean repository

* fix err occurs in TestCancelledContext

* fix err in TestCancelledContext which is nil

* fix err in TestCancelledContext which is nil, occurs occasionally

* fix unittest err in TestCancelledContext which occurs occasionally

* fix ineffectual assignment to err when running lint

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <[email protected]>

* Update exporters/otlp/otlpmetric/otlpmetrichttp/doc.go

Co-authored-by: Tyler Yahn <[email protected]>

* Update exporters/otlp/otlpmetric/otlpmetrichttp/doc.go

Co-authored-by: Tyler Yahn <[email protected]>

* del options that not used in http exporter metrics

Co-authored-by: Tyler Yahn <[email protected]>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants