Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename component.TraceExporter to component.TracesExporter #2027

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

bogdandrutu
Copy link
Member

Fixes #1975

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team October 28, 2020 20:46
@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #2027 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2027      +/-   ##
==========================================
- Coverage   91.91%   91.89%   -0.03%     
==========================================
  Files         276      276              
  Lines       16552    16552              
==========================================
- Hits        15214    15210       -4     
- Misses        922      924       +2     
- Partials      416      418       +2     
Impacted Files Coverage Δ
exporter/exporterhelper/factory.go 100.00% <ø> (ø)
exporter/exportertest/nop_exporter.go 100.00% <ø> (ø)
exporter/jaegerexporter/exporter.go 88.23% <ø> (ø)
exporter/loggingexporter/factory.go 75.60% <ø> (ø)
exporter/opencensusexporter/factory.go 100.00% <ø> (ø)
exporter/opencensusexporter/opencensus.go 87.93% <ø> (ø)
component/componenttest/example_factories.go 88.14% <100.00%> (ø)
exporter/exporterhelper/tracehelper.go 100.00% <100.00%> (ø)
exporter/fileexporter/factory.go 88.46% <100.00%> (ø)
exporter/jaegerexporter/factory.go 92.30% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 371514c...36a852e. Read the comment docs.

@tigrannajaryan
Copy link
Member

Need to resolve conflicts.

@tigrannajaryan tigrannajaryan merged commit 2c8915a into open-telemetry:master Oct 29, 2020
@bogdandrutu bogdandrutu deleted the tracesexporter branch January 13, 2021 18:48
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…y#2027)

* export ToZipkinSpanModels for use outside this library

* Update CHANGELOG.md
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
* Remove outdated -compat=1.17 for go mod tidy in makefile

* Fix dead links in deployments/puppet/README.md

* Update auto instrumentation java agent to v1.16.0
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename exporter component.TraceExporter to component.TracesExporter, and equivalent Create method
2 participants