Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InitFromAttributeMap, use CopyTo if needed. #2042

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team October 30, 2020 19:11
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #2042 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2042      +/-   ##
==========================================
+ Coverage   91.92%   91.93%   +0.01%     
==========================================
  Files         282      282              
  Lines       16797    16786      -11     
==========================================
- Hits        15440    15433       -7     
+ Misses        933      931       -2     
+ Partials      424      422       -2     
Impacted Files Coverage Δ
consumer/pdata/common.go 96.50% <100.00%> (-0.12%) ⬇️
translator/internaldata/resource_to_oc.go 94.52% <0.00%> (+5.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d7a1f...c8c2f6e. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 99ea2df into open-telemetry:master Oct 30, 2020
@bogdandrutu bogdandrutu deleted the rmunuse branch October 30, 2020 19:50
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
* Use a single wait strategy if only one provided

* add a startupTimeout for the overall container with a default of 5 minutes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants