Refactor build_and_tests GHA workflow before for migrating publish jobs

[shovnik]

Which problem is this solving?

As part of issue, this pull request does some naming changes and refactoring on the already migrated build_and_test workflows jobs in preparation for migrating the remaining windows-msi, publish-dev and publish-stable jobs in the following PR
This PR must be reviewed and merged before merging the final migration PR. The purpose of this PR is to remove changes to existing jobs from the final migration PR.

What changes are made in this PR?

• All step names are consistent across jobs (descriptive and capitalized except articles/prepositions)
• Bash logic that is complex or to be reused in the new jobs was extracted into shell scripts
• Permissions were added to binaries before upload to allows windows machines to execute them. This meant archiving the binaries with tar before upload for them to retain permissions.
  cc- @alolita, @AzfaarQureshi

[codecov]

Codecov Report

Merging #2313 (80d9700) into master (d47baee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2313   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         272      272           
  Lines       15337    15337           
=======================================
  Hits        14117    14117           
  Misses        840      840           
  Partials      380      380           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47baee...80d9700. Read the comment docs.

[shovnik]

@bogdandrutu I separated out the naming changes and refactoring to the existing workflow into a separate PR as requested. Please take a look.

[bogdandrutu]

why is this needed vs the whole path?

[shovnik]

The reason I archived the file was to preserve the execute permissions on the binaries created. Specifically on the windows-msi job, there was no way to easily chmod +x the binary once downloaded given the OS. Also, this prevents having to add permissions to the binaries everytime it is downloaded although extracting the archive is required instead.

[bogdandrutu]

I am fine to always add the chmod +x instead of archive. Maybe leave also a TODO to explain this.

[shovnik]

The only issue is that I cannot do the chmod for the windows job (In PR 3/3), this was a workaround specifically for that. I can remove the archiving from tool binaries, but it is needed for the collector binaries which the windows-msi job uses.

[shovnik]

Removed the archiving from all the tool binaries, because it was unnecessary. I still need to archive the collector binary produced from cross-compile because it requires execute permissions to run in windows-msi.

[bogdandrutu]

It does not seem to be reflected in the code.

[shovnik]

I pushed my amend to the wrong Git branch, did not mean to mislead sorry. All instances of tool archive should be gone now.