Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish unitests results to the pull requests #2531

Closed
wants to merge 1 commit into from

Conversation

bogdandrutu
Copy link
Member

Updates #1234

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team February 22, 2021 20:43
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #2531 (3e3e583) into main (379645d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2531   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         265      265           
  Lines       15083    15083           
=======================================
  Hits        13834    13834           
  Misses        867      867           
  Partials      382      382           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347cfa9...8639dda. Read the comment docs.

Comment on lines 153 to 157
- name: Publish Unit Test Results
if: always()
uses: actions/upload-artifact@v1
uses: EnricoMi/publish-unit-test-result-action@v1.9
with:
name: unittests-results
path: test-results/junit/unittests.xml
files: test-results/junit/unittests.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? Is it supposed to publish the results somewhere visible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to figure that out, for the moment there is a permission issue that I hope I fixed

Signed-off-by: Bogdan Drutu <[email protected]>
Copy link
Member

@gramidt gramidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows unit test failure was resolved in #2474?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Mar 10, 2021
@bogdandrutu bogdandrutu deleted the runtests branch March 18, 2021 16:04
@gramidt
Copy link
Member

gramidt commented May 12, 2021

@bogdandrutu - Was this meant to be closed? Were the permissions issues mentioned in comments resolved?

Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants