-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish unitests results to the pull requests #2531
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2531 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 265 265
Lines 15083 15083
=======================================
Hits 13834 13834
Misses 867 867
Partials 382 382 Continue to review full report at Codecov.
|
.github/workflows/build-and-test.yml
Outdated
- name: Publish Unit Test Results | ||
if: always() | ||
uses: actions/upload-artifact@v1 | ||
uses: EnricoMi/publish-unit-test-result-action@v1.9 | ||
with: | ||
name: unittests-results | ||
path: test-results/junit/unittests.xml | ||
files: test-results/junit/unittests.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? Is it supposed to publish the results somewhere visible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to figure that out, for the moment there is a permission issue that I hope I fixed
7a6798e
to
c7ae564
Compare
66f434b
to
3e3e583
Compare
Signed-off-by: Bogdan Drutu <[email protected]>
3e3e583
to
8639dda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows unit test failure was resolved in #2474?
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
@bogdandrutu - Was this meant to be closed? Were the permissions issues mentioned in comments resolved? |
Updates #1234
Signed-off-by: Bogdan Drutu [email protected]