Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loggingexporter: add support for AttributeMap #2609

Merged
merged 1 commit into from
Mar 5, 2021
Merged

loggingexporter: add support for AttributeMap #2609

merged 1 commit into from
Mar 5, 2021

Conversation

sumo-drosiek
Copy link
Member

Description:

Add printing map to logging exporter.
Currently maps are printed as <Unknown OpenTelemetry attribute value type MAP>. An idea of the PR is to put it in more usable form. Nested maps are stringified jsons

Example output:

Some text: {
     -> foo: STRING(test)
     -> zoo: MAP({"bar":13})
}

Testing:
unit tests

@sumo-drosiek sumo-drosiek requested a review from a team March 5, 2021 13:50
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #2609 (df01246) into main (bf8b945) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2609   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files         271      271           
  Lines       15446    15455    +9     
=======================================
+ Hits        14214    14223    +9     
  Misses        850      850           
  Partials      382      382           
Impacted Files Coverage Δ
exporter/loggingexporter/logging_exporter.go 96.40% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf8b945...df01246. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit b9d0797 into open-telemetry:main Mar 5, 2021
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants