Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for cloud semantic conventions #2809

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Conversation

jrcamp
Copy link
Contributor

@jrcamp jrcamp commented Mar 25, 2021

cloud.infrastructure_service -> cloud.platform
cloud.zone -> cloud.availability_zone

These changes were made in:

open-telemetry/opentelemetry-specification#1495
open-telemetry/opentelemetry-specification#1530

Will make changes in contrib next.

@jrcamp jrcamp requested a review from a team March 25, 2021 22:17
cloud.infrastructure_service -> cloud.platform
cloud.zone -> cloud.availability_zone

These changes were made in:

open-telemetry/opentelemetry-specification#1495
open-telemetry/opentelemetry-specification#1530

Will make changes in contrib next.
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2809 (7a1e77a) into main (09f29af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2809   +/-   ##
=======================================
  Coverage   91.66%   91.67%           
=======================================
  Files         293      293           
  Lines       15629    15635    +6     
=======================================
+ Hits        14327    14333    +6     
  Misses        891      891           
  Partials      411      411           
Impacted Files Coverage Δ
internal/goldendataset/resource_generator.go 98.26% <100.00%> (ø)
translator/conventions/opentelemetry.go 100.00% <100.00%> (ø)
translator/internaldata/oc_to_resource.go 100.00% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 94.11% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f29af...7a1e77a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants