Rename ForEach with Range to be consistent with sync.Map #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2931 +/- ##
==========================================
+ Coverage 91.66% 91.68% +0.01%
==========================================
Files 312 312
Lines 15317 15338 +21
==========================================
+ Hits 14041 14062 +21
Misses 870 870
Partials 406 406
Continue to review full report at Codecov.
|
consumer/pdata/common.go
Outdated
| // ... | ||
| // }) | ||
| func (am AttributeMap) ForEach(f func(k string, v AttributeValue)) { | ||
| func (am AttributeMap) Range(f func(k string, v AttributeValue)) { |
There was a problem hiding this comment.
If we aim for consistency also make f return bool to stop iteration like sync.Map.Range does. That's useful for search operations.
There was a problem hiding this comment.
@tigrannajaryan sure, changed :)
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #2488
Signed-off-by: Bogdan Drutu [email protected]