Optimize dpgSignature function in Prometheus receiver #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2945 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 312 312
Lines 15351 15356 +5
=======================================
+ Hits 14059 14064 +5
Misses 883 883
Partials 409 409
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Apr 15, 2021
x13n
force-pushed
the
dpgsignature
branch
2 times, most recently
from
8df19b8
to
d64f1c7
Compare
|
Just rebased this to HEAD, but contrib_tests keep on failing. Anything else I should be doing about this? The error is not related to this change. |
This function is invoked very often, which leads to high CPU usage when collecting Prometheus metrics. Benchmark results on my machine show 3x less CPU and almost 4x less memory used. Since I'm also changing the format of returned values (dropping superfluous characters), it will reduce overall memory usage of the receiver, because they are used as map keys. Benchmark result before this change: Benchmark_dpgSignature-6 1284531 969.6 ns/op 120 B/op 7 allocs/op Benchmark result after this change: Benchmark_dpgSignature-6 3515179 313.9 ns/op 32 B/op 2 allocs/op
|
Ok, looks like another rebase solved the problem. |
bogdandrutu
approved these changes
Apr 19, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…lfx-agent (open-telemetry#2945) * Bump github.com/prometheus/common in /pkg/signalfx-agent Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.39.0 to 0.42.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.39.0...v0.42.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * make tidy --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
dpgSignature is invoked very often, which leads to high CPU usage when
collecting Prometheus metrics.
Benchmark results on my machine show 3x less CPU and almost 4x less
memory used. Since I'm also changing the format of returned values
(dropping superfluous characters), it will reduce overall memory usage
of the receiver, because they are used as map keys.
Benchmark result before this change:
Benchmark_dpgSignature-6 1284531 969.6 ns/op 120 B/op 7 allocs/op
Benchmark result after this change:
Benchmark_dpgSignature-6 3515179 313.9 ns/op 32 B/op 2 allocs/op
Testing: Added benchmark and updated unit tests.