-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standarize Settings instead of Params and Parameters #2991
Standarize Settings instead of Params and Parameters #2991
Conversation
@bogdandrutu @tigrannajaryan please take a look for this proposal |
Codecov Report
@@ Coverage Diff @@
## main #2991 +/- ##
==========================================
- Coverage 92.06% 91.65% -0.42%
==========================================
Files 313 312 -1
Lines 15439 15428 -11
==========================================
- Hits 14214 14140 -74
- Misses 817 881 +64
+ Partials 408 407 -1
Continue to review full report at Codecov.
|
2aa2886
to
72ef9d6
Compare
Fixes open-telemetry#2650 Changes: Replace: ReceiverCreateParams, ProcessorCreateParams, ExtensionCreateParams and ExporterCreateParams with ComponentSettings struct Replace all dependencies in Extensions, Exporters, Processors and Receivers Replace Parameters and settings structs with new struct Settings Replace dependencies in service and main Update tests Signed-off-by: Patryk Matyjasek <[email protected]> # Conflicts: # exporter/kafkaexporter/factory.go # exporter/kafkaexporter/factory_test.go # exporter/kafkaexporter/kafka_exporter.go # exporter/kafkaexporter/kafka_exporter_test.go # exporter/prometheusexporter/factory.go # receiver/jaegerreceiver/jaeger_agent_test.go # receiver/jaegerreceiver/trace_receiver_test.go # receiver/kafkareceiver/factory.go # receiver/kafkareceiver/factory_test.go # receiver/kafkareceiver/kafka_receiver.go # receiver/kafkareceiver/kafka_receiver_test.go # Conflicts: # processor/batchprocessor/batch_processor.go # processor/batchprocessor/batch_processor_test.go # processor/batchprocessor/factory.go # processor/filterprocessor/filter_processor_test.go # service/application.go # Conflicts: # cmd/otelcol/main.go # component/component.go # component/exporter.go # component/extension.go # component/processor.go # component/processor_test.go # component/receiver.go # exporter/exporterhelper/factory_test.go # extension/extensionhelper/factory_test.go # processor/batchprocessor/batch_processor.go # processor/processorhelper/factory_test.go # receiver/jaegerreceiver/factory.go # receiver/jaegerreceiver/trace_receiver_test.go # receiver/otlpreceiver/factory.go # receiver/prometheusreceiver/factory.go # receiver/receiverhelper/factory_test.go # service/application.go # service/application_test.go # service/defaultcomponents/default_exporters_test.go # service/defaultcomponents/default_extensions_test.go # service/defaultcomponents/default_processors_test.go # service/defaultcomponents/default_receivers_test.go # service/internal/builder/exporters_builder.go # service/internal/builder/extensions_builder.go # service/internal/builder/pipelines_builder.go # service/internal/builder/receivers_builder.go # service/service.go # service/service_test.go # testbed/testbed/otelcol_runner.go
Fix Windows building Signed-off-by: Patryk Matyjasek <[email protected]> # Conflicts: # CHANGELOG.md
72ef9d6
to
44f32bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the direction, we should probably start by doing smaller PRs, like changing the service package initially.
Thanks @bogdandrutu for the response. I'll split it into smaller PRs. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@pmatyjasek-sumo is this PR still useful? |
No. I'm closing it |
A proposal solution of standarize constructors parameters
Description:
Fixes #2650
Changes:
Replace: ReceiverCreateParams, ProcessorCreateParams, ExtensionCreateParams and ExporterCreateParams with ComponentSettings struct
Replace all dependencies in Extensions, Exporters, Processors and Receivers
Replace Parameters and settings structs with new struct Settings
Replace dependencies in service and main
Update tests
Signed-off-by: Patryk Matyjasek [email protected]
Link to tracking Issue:
#2650
Testing: < Describe what testing was performed and which tests were added.>
UT
Documentation: < Describe the documentation added.>
In code comments