Remove unnecessary proto marshaler tests, avoid using InternalRep in otlprecv #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otlprecv Signed-off-by: Bogdan Drutu <[email protected]>
tigrannajaryan
requested changes
Jun 8, 2021
Comment on lines
-246
to
-258
| func TestJsonMarshaling(t *testing.T) { | ||
| m := jsonpb.Marshaler{} | ||
| json, err := m.MarshalToString(&resourceSpansOtlp) | ||
| assert.NoError(t, err) | ||
|
|
||
| var resourceSpansOtlp2 otlptrace.ResourceSpans | ||
| err = jsonpb.UnmarshalString(json, &resourceSpansOtlp2) | ||
| assert.NoError(t, err) | ||
|
|
||
| assert.EqualValues(t, resourceSpansOtlp, resourceSpansOtlp2) | ||
| } | ||
|
|
||
| func TestJsonUnmarshaling(t *testing.T) { |
There was a problem hiding this comment.
These are important tests that verify JSON marshaling. Why delete these?
There was a problem hiding this comment.
We are testing that the jsonpb (from a third-party library) does the right thing. Unit-tests should be for our code and we should not write unit-tests to test third-party libraries unless a specific bug is covered.
There was a problem hiding this comment.
Friendly ping @tigrannajaryan
tigrannajaryan
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3104
Signed-off-by: Bogdan Drutu [email protected]