Update testbed modules #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2019 11:09
These are different than the ones on root and if you use an IDE (depending on the settings) these files may get automatically changed constantly. This update to go.mod avoids that.
pjanotti
requested review from
bogdandrutu,
flands,
songy23 and
tigrannajaryan
as code owners
tigrannajaryan
approved these changes
Sep 20, 2019
pjanotti
commented
Sep 20, 2019
| github.com/spf13/viper v1.4.0 | ||
| github.com/stretchr/testify v1.3.0 | ||
| go.opencensus.io v0.22.0 | ||
| github.com/shirou/w32 v0.0.0-20160930032740-bb4de0191aa4 // indirect |
There was a problem hiding this comment.
why adding this one? it is used by github.com/shirou/gopsutil/process that is used on testbed
$ go mod why github.com/shirou/w32
# github.com/shirou/w32
github.com/open-telemetry/opentelemetry-service/testbed/testbed
github.com/shirou/gopsutil/process
github.com/shirou/w32
songy23
approved these changes
Sep 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
======================================
Coverage 74.4% 74.4%
======================================
Files 115 115
Lines 6708 6708
======================================
Hits 4991 4991
Misses 1470 1470
Partials 247 247Continue to review full report at Codecov.
|
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are different than the ones on root and if you use an IDE (depending on the settings) these files may get automatically changed constantly. This update to go.mod avoids that.