Add grpc creations test case to jaeger receiver #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huikang
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
|
Please add an issue to fix the failing test if no such issue already exists. |
|
@tigrannajaryan , the issue seems related to #41 |
huikang
force-pushed
the
jaeger-receiver-coverage
branch
from
df638ee
to
67b77de
Compare
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 75.72% 75.79% +0.06%
==========================================
Files 120 120
Lines 7345 7345
==========================================
+ Hits 5562 5567 +5
+ Misses 1520 1516 -4
+ Partials 263 262 -1
Continue to review full report at Codecov.
|
|
Hi @huikang could you please rebase this one? |
huikang
force-pushed
the
jaeger-receiver-coverage
branch
from
67b77de
to
0cc2cbe
Compare
|
@huikang something went wrong with CI could you please amend the commit and force push to rebuild it? Thanks. |
- increase test coverage for tls Signed-off-by: Hui Kang <[email protected]>
huikang
force-pushed
the
jaeger-receiver-coverage
branch
from
0cc2cbe
to
d991492
Compare
Done. Thanks. |
tigrannajaryan
approved these changes
Jan 23, 2020
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…--config (open-telemetry#450) * Allow setting both SPLUNK_CONFIG and --config with cmdline priority * testutils: add Collector.WillFail(), connect Args, and specify config dynamically * Add endtoend doc.go for integration-test target success
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hui Kang [email protected]