Processor doc: add description for queued processor #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huikang
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 122 122
Lines 7574 7574
=======================================
Hits 5769 5769
Misses 1534 1534
Partials 271 271Continue to review full report at Codecov.
|
rghetia
approved these changes
Dec 11, 2019
processor/README.md
Outdated
| receiver or previous processor to the next span processor. On | ||
| receiving trace data, the queued processor produces items to the queue. At the | ||
| same time, the queued processor has one or more workers which consume the trace | ||
| data in the queue by sending them to the next span processor. |
There was a problem hiding this comment.
maybe add some description about retry logic?
There was a problem hiding this comment.
Updated. Thanks for your feedback.
huikang
force-pushed
the
doc-queued_processor
branch
from
e0f1779
to
465754b
Compare
huikang
force-pushed
the
doc-queued_processor
branch
from
465754b
to
c6e9001
Compare
|
@pjanotti , updated. Thanks for the suggestions. |
processor/README.md
Outdated
| Received trace data is enqueued immediately if the queue is not full . At the | ||
| same time, the processor has one or more workers which consume the trace | ||
| data in the queue by sending them to the next processor. On failure of | ||
| consuming the trace data, the processor retries after some backoff delay |
There was a problem hiding this comment.
Unclear what "consuming" refers to. Maybe say instead: "If relaying the trace data to the next processor or exporter in the pipeline fails ..."
owais
approved these changes
Jan 15, 2020
Signed-off-by: Hui Kang <[email protected]>
huikang
force-pushed
the
doc-queued_processor
branch
from
c6e9001
to
c9d078b
Compare
pjanotti
approved these changes
Jan 15, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…try#454) * Drop entry from correlation map Entry used to contain stuff like TTL, but right now the notion of entry was dropped from the spec. * Compute exact size of the correlations map The map will be immutable, so spend some more time to ensure that we will not unnecessarily waste some memory on a basically read-only map. * Allow dropping keys from correlations map This is to follow the spec. Before this change it was possible in an awkward way by using Foreach to gather and filter the key-value pairs, and then calling NewMap with a MultiKV MapUpdate. * Document the correlation package * Add missing license blurbs in correlation package * Add tests for deleting items in correlations * Factor out getting map size and test it This is an implementation detail that can't be tested in a black-box manner. * Fix copyright dates * Simplify/disambiguate keySet function parameters/return values * Fix typo in Apply docs * Fix test names * Explain the nonsense of dropping keys from new map
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#454) Bumps [boto3](https://github.com/boto/boto3) from 1.17.85 to 1.17.88. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.17.85...1.17.88) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hui Kang [email protected]