Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expandStringValues function support to map[string]interface{} #4748

Merged
merged 3 commits into from
Jan 25, 2022
Merged

expandStringValues function support to map[string]interface{} #4748

merged 3 commits into from
Jan 25, 2022

Conversation

kilingzhang
Copy link
Contributor

Description:

The use and expansion of environment variables is supported in the Collector configuration. For example:

processors:
  attributes/example:
    actions:
      - key: "${DB_KEY}"
        action: "${OPERATION}"

@kilingzhang kilingzhang requested review from a team and Aneurysm9 January 25, 2022 19:12
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 25, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@bogdandrutu
Copy link
Member

@kilingzhang consider to add a test to prove that this is needed. See #4649 where I explicitly added tests to prove that is not needed, maybe I missed something, but would be good to have a unit tests for that.

@bogdandrutu bogdandrutu reopened this Jan 25, 2022
@bogdandrutu
Copy link
Member

Pressed by mistake closed instead of comment sorry.

@codecov
Copy link

codecov bot commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #4748 (3f87dc5) into main (21847f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4748   +/-   ##
=======================================
  Coverage   90.72%   90.73%           
=======================================
  Files         179      179           
  Lines       10690    10696    +6     
=======================================
+ Hits         9699     9705    +6     
  Misses        770      770           
  Partials      221      221
Impacted Files Coverage Δ
config/configmapprovider/expand.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21847f4...3f87dc5. Read the comment docs.

@kilingzhang
Copy link
Contributor Author

@kilingzhang consider to add a test to prove that this is needed. See #4649 where I explicitly added tests to prove that is not needed, maybe I missed something, but would be good to have a unit tests for that.

ok . I added some tests to prove it was necessary .

bogdandrutu
bogdandrutu approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. Thanks

@bogdandrutu
Copy link
Member

Can you please rebase (resolve merge conflicts)?

kilingzhang and others added 3 commits January 25, 2022 14:56
expandStringValues function support to map[string]interface{}
e4da239 
eg.
processors:
  attributes/example:
    actions:
      - key: "${DB_KEY}"
        action: "${OPERATION}"
add some test to prove that this is needed .
238f4c5
update changelog
3f87dc5
@bogdandrutu bogdandrutu enabled auto-merge (squash) January 25, 2022 23:06
@bogdandrutu bogdandrutu merged commit 74d11db into open-telemetry:main Jan 25, 2022
bogdandrutu pushed a commit that referenced this pull request Jan 25, 2022
@kilingzhang
patch release 0.43.1 (#4754)
dea20b5 
* formatting fixes (#4751)

Cleaning up the changelog with formatting fixes.

* expandStringValues function support to map[string]interface{} (#4748)

* expandStringValues function support to map[string]interface{}

eg.
processors:
  attributes/example:
    actions:
      - key: "${DB_KEY}"
        action: "${OPERATION}"

* add some test to prove that this is needed .

* update changelog

Co-authored-by: Alex Boten <[email protected]>

* prepare v0.43.1 release (#4753)

This release includes a regression in the 0.43.0 release.

Co-authored-by: kilingzhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilingzhang @bogdandrutu @codeboten