Remove "Attribute" part from common pdata collections names #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
commented
Mar 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #5001 +/- ##
==========================================
- Coverage 91.08% 91.05% -0.03%
==========================================
Files 180 180
Lines 10700 10788 +88
==========================================
+ Hits 9746 9823 +77
- Misses 737 747 +10
- Partials 217 218 +1
Continue to review full report at Codecov.
|
bogdandrutu
approved these changes
Mar 15, 2022
codeboten
approved these changes
Mar 15, 2022
dmitryax
force-pushed
the
rename-map-slice
branch
5 times, most recently
from
d664c69
to
09fef01
Compare
bogdandrutu
reviewed
Mar 16, 2022
Comment on lines
+59
to
+115
| NewMap = pdata.NewMap | ||
| NewMapFromRaw = pdata.NewMapFromRaw |
There was a problem hiding this comment.
nit: separate PR, I would prefer to rename internal/pdata to maybe just internal, I am confused about the 2 packages named the same, when code refers to one vs the other.
|
Please rebase |
dmitryax
force-pushed
the
rename-map-slice
branch
11 times, most recently
from
e9763d3
to
5054199
Compare
bogdandrutu
approved these changes
Mar 17, 2022
dmitryax
force-pushed
the
rename-map-slice
branch
2 times, most recently
from
e752665
to
87b96f4
Compare
dmitryax
force-pushed
the
rename-map-slice
branch
2 times, most recently
from
e38b217
to
df3cd35
Compare
bogdandrutu
approved these changes
Mar 21, 2022
All of the pdata wrappers for collections include Attribute part in its name because the fields used to be part of the attributes fields only. But it's not the case anymore since `pdata.LogRecord.Body` uses AnyValue that can contain any common collection. This change renames AttributeMap and AttributeValueSlice collections by removing Attribute part from their names and making them consistent.
dmitryax
force-pushed
the
rename-map-slice
branch
from
df3cd35
to
1e2bb7e
Compare
bogdandrutu
approved these changes
Mar 21, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…emetry#5001) * Remove "Attribute" part from common pdata collections names All of the pdata wrappers for collections include Attribute part in its name because the fields used to be part of the attributes fields only. But it's not the case anymore since `pdata.LogRecord.Body` uses AnyValue that can contain any common collection. This change renames AttributeMap and AttributeValueSlice collections by removing Attribute part from their names and making them consistent. * Change NewMapFromRaw to take interface{} Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the pdata wrappers for collections include Attribute part in its name because the fields used to be part of the attributes fields only. But it's not the case anymore since pdata.LogRecord.Body uses AnyValue that can contain any common collection. This change renames AttributeMap and AttributeValueSlice collections by removing Attribute part from their names and making them consistent.
Renames:
pdata.AttributeMapstruct in favor ofpdata.Mappdata.NewAttributeMapfunc in favor ofpdata.NewMappdata.NewAttributeMapFromMapfunc in favor ofpdata.NewMapFromRawpdata.AttributeValueSlicestruct in favor ofpdata.Slicepdata.NewAttributeValueSlicefunc in favor ofpdata.NewSliceLink to tracking Issue: #4988