-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(receiver/otlpreceiver): make the configuration HttpServerSettings public #8176
fix(receiver/otlpreceiver): make the configuration HttpServerSettings public #8176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This was added in #7570, I see no discussion there on this being made private for any specific reason, and our policy today is to have all configuration as part of the public API
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8176 +/- ##
==========================================
+ Coverage 90.25% 90.27% +0.01%
==========================================
Files 301 301
Lines 15551 15581 +30
==========================================
+ Hits 14035 14065 +30
Misses 1227 1227
Partials 289 289
☔ View full report in Codecov by Sentry. |
@lpegoraro can you add a changelog entry? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @lpegoraro, can you please add an entry to the changelog, by adding a new file to .chloggen?
hey, just added. not sure if it is by standards, let me know if anything. |
Co-authored-by: Pablo Baeyens <[email protected]>
Do we need anything else? |
Co-authored-by: Dmitrii Anoshin <[email protected]>
Let's rename the struct first, since we have the chance to do it now comfortably
any news on this? |
Can you merge/rebase main, so the tests pass? |
Description: Make the configuration for the OTLP Receiver httpServerSettings to be public
Fixing the bug opened #8175
Link to tracking Issue:#8175