[builder] remove the need for adding a replace statement #8763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The builder inserted a replace statement for the cloud.google.com/go to address an ambiguous import issue. This has the negative side effect of breaking go install for any modules that use the builder to generate a go.mod. This change removes that replace statement. Instead, the builder explicitly runs `go get cloud.google.com/go` as part of the generation process. Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
@codeboten PTAL at the linter failures |
jmacd
approved these changes
Oct 26, 2023
codeboten
commented
Oct 26, 2023
dmitryax
approved these changes
Oct 26, 2023
Signed-off-by: Alex Boten <[email protected]>
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
Updating core to bring in the new builder, which no longer uses a replace in its template (open-telemetry/opentelemetry-collector#8763) --------- Signed-off-by: Alex Boten <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Nov 3, 2023
**Description:** Follow up to #8763
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…etry#28652) Updating core to bring in the new builder, which no longer uses a replace in its template (open-telemetry/opentelemetry-collector#8763) --------- Signed-off-by: Alex Boten <[email protected]>
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…etry#28652) Updating core to bring in the new builder, which no longer uses a replace in its template (open-telemetry/opentelemetry-collector#8763) --------- Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builder inserted a replace statement for the cloud.google.com/go to address an ambiguous import issue. This has the negative side effect of breaking go install for any modules that use the builder to generate a go.mod. This change removes that replace statement. Instead, the builder explicitly runs
go get cloud.google.com/goas part of the generation process.