Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/debug] change default verbosity from normal to basic #8846

Conversation

andrzej-stencel
Copy link
Member

Description:

This change has currently no effect, as basic and normal verbosity share the same behavior. This might change in the future though, with the normal verbosity being more verbose than it currently is (see #7806). This is why we are changing the default to basic, which is expected to stay at the current level of verbosity (one line per batch).

Link to tracking Issue:

@andrzej-stencel andrzej-stencel requested review from a team and jpkrohling November 11, 2023 20:46
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df8aaae) 90.87% compared to head (9c1fd11) 90.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8846      +/-   ##
==========================================
- Coverage   90.87%   90.86%   -0.02%     
==========================================
  Files         317      317              
  Lines       17225    17225              
==========================================
- Hits        15653    15651       -2     
- Misses       1281     1282       +1     
- Partials      291      292       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrzej-stencel andrzej-stencel added the exporter/debug Issues related to the Debug exporter label Nov 13, 2023
@codeboten codeboten merged commit f96d155 into open-telemetry:main Nov 15, 2023
32 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 15, 2023
@andrzej-stencel andrzej-stencel deleted the debug-exporter-default-verbosity-basic branch November 15, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/debug Issues related to the Debug exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants