Implement VMMetrics factory and config V2 #90
Conversation
Github issue: open-telemetry#35 Testing done: make && make otelsvc
tigrannajaryan
requested review from
bogdandrutu,
flands,
pjanotti and
songy23
as code owners
There was a problem hiding this comment.
LGTM. Do you want to clean up the old config? https://github.com/open-telemetry/opentelemetry-service/blob/4979bbd344d94c28958b5c74f0a6c570efb06a02/receiver/vmmetricsreceiver/metrics_receiver.go#L112-L128
Categorize namespaces of each item into:
- exporters
- interceptors
- zpages
which aesthetically looks nicer than the original but also
gives users better context and control over what the agent
does.
For example here is the new configuration file:
```yaml
interceptors:
opencensus:
address: "127.0.0.1:55678"
exporters:
stackdriver:
project: "project-id"
enable_tracing: true
zipkin:
endpoint: "http://localhost:9411/api/v2/spans"
datadog:
enable_tracing: false
zpages:
port: 55679
```
Fixes #90
@songy23 yes, it is in my todo list. I just want to first have feature parity in new config implementation and then start deleting old config support. |
|
Keeping the support for old config allows to build old occollector executable and run it and compare with otelsvc behavior. Very useful for testing. |
| // StartMetricsReception scrapes VM metrics based on the OS platform. | ||
| func (vmr *Receiver) StartMetricsReception(ctx context.Context, asyncErrorChan chan<- error) error { | ||
| func (vmr *Receiver) StartMetricsReception(host receiver.Host) error { |
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=========================================
Coverage ? 69.87%
=========================================
Files ? 98
Lines ? 6304
Branches ? 0
=========================================
Hits ? 4405
Misses ? 1669
Partials ? 230
Continue to review full report at Codecov.
|
|
Results as seen in Prometheus:
|
…elemetry#90) Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 0.15.0 to 0.16.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v0.15.0...v0.16.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Github issue: #35
Testing done: make && make otelsvc