Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] make genotelcorecol #9020

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[chore] make genotelcorecol #9020

merged 1 commit into from
Nov 30, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Nov 30, 2023

No description provided.

@atoulme atoulme requested review from a team and codeboten November 30, 2023 16:58
@mx-psi
Copy link
Member

mx-psi commented Nov 30, 2023

I don't understand what is broken nor why does this fix it. The first PR where this started failing is #9014, yet this is a docs only PR, so I assume something changed upstream. Do we know what happened? I am kind of hesitant to merge this without understanding it better

@atoulme
Copy link
Contributor Author

atoulme commented Nov 30, 2023

No idea, but this is similar to open-telemetry/opentelemetry-collector-contrib#29570

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bdeee09) 91.57% compared to head (060db10) 91.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9020   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files         316      316           
  Lines       17147    17147           
=======================================
  Hits        15702    15702           
  Misses       1150     1150           
  Partials      295      295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member

dmitryax commented Nov 30, 2023

this is a result of removing the replace statements for the google sdk. there is an issue for that open-telemetry/opentelemetry-collector-contrib#28839

cc @codeboten , we need to think how we can fix this

@dmitryax dmitryax merged commit cd963da into open-telemetry:main Nov 30, 2023
32 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 30, 2023
@atoulme atoulme deleted the fix_main branch November 30, 2023 21:52
pantuza pushed a commit to pantuza/opentelemetry-collector that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants