Fanout consumer does not need to mutate in some cases #9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
fanout-non-mutate
branch
from
e2ec348
to
cd06e94
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9062 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 316 316
Lines 17181 17184 +3
=======================================
+ Hits 15720 15723 +3
Misses 1165 1165
Partials 296 296 ☔ View full report in Codecov by Sentry. |
djaglowski
force-pushed
the
fanout-non-mutate
branch
from
cd06e94
to
2746535
Compare
TylerHelmuth
approved these changes
Dec 11, 2023
dmitryax
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9053.
@dmitryax pointed out here that the fanout consumer will pass original data to a non-mutating consumer if any is available. This PR incorporates that point and updates test expectations accordingly.