-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confignet] Add DialerTimeout config option #9066
[confignet] Add DialerTimeout config option #9066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this, I was looking at this Friday, and I'm curious what your thoughts are around whether or not this feature will allow the removal of dialer timeouts configuration in other components.
please take a look at the failing tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9066 +/- ##
==========================================
- Coverage 91.49% 91.47% -0.03%
==========================================
Files 316 320 +4
Lines 17181 17187 +6
==========================================
+ Hits 15720 15722 +2
Misses 1165 1165
- Partials 296 300 +4 ☔ View full report in Codecov by Sentry. |
If a component already allowed configuring a The carbonexporter is an example of a Contrib component that does this. It looks like the signalfx exporter also does this: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/95cb7336823185453e7a6538dc38988ee6596042/exporter/signalfxexporter/internal/dimensions/dimclient.go#L92-L96. But in this case they also take advantage of additional This kinda gets to a question about how much of a wrapper |
Description:
Adds a new
dialer_timeout
config option toconfignet
to allow configuring the timeout of the connection.Link to tracking Issue:
Closes #4331
Testing:
Added new unit tests
Documentation:
Updated readme