Fix leaking goroutine in memorylimiter

.chloggen/fix-leaking-goroutine-in-memorylimiter.yaml

@@ -0,0 +1,25 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: bug_fix
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: memorylimiterprocessor
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Fixed leaking goroutines from memorylimiterprocessor
+
+# One or more tracking issues or pull requests related to the change
+issues: [9099]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []

processor/memorylimiterprocessor/memorylimiter.go

@@ -63,6 +63,9 @@ type memoryLimiter struct {
 
 	refCounterLock sync.Mutex
 	refCounter     int
+	waitGroup      sync.WaitGroup
+	closeOnce      sync.Once
+	closed         chan struct{}
 }
 
 // Minimum interval between forced GC when in soft limited mode. We don't want to
@@ -98,6 +101,7 @@ func newMemoryLimiter(set processor.CreateSettings, cfg *Config) (*memoryLimiter
 		logger:         logger,
 		mustRefuse:     &atomic.Bool{},
 		obsrep:         obsrep,
+		closed:         make(chan struct{}),
 	}
 
 	return ml, nil
@@ -141,6 +145,10 @@ func (ml *memoryLimiter) shutdown(context.Context) error {
 		return errShutdownNotStarted
 	} else if ml.refCounter == 1 {
 		ml.ticker.Stop()
+		ml.closeOnce.Do(func() {
+			close(ml.closed)
+		})
+		ml.waitGroup.Wait()
 	}
 	ml.refCounter--
 	return nil
@@ -226,8 +234,16 @@ func (ml *memoryLimiter) startMonitoring() {
 
 	ml.refCounter++
 	if ml.refCounter == 1 {
+		ml.waitGroup.Add(1)
 		go func() {
-			for range ml.ticker.C {
+			defer ml.waitGroup.Done()
+
+			for {
+				select {
+				case <-ml.ticker.C:
+				case <-ml.closed:
+					return
+				}
 				ml.checkMemLimits()
 			}
 		}()