[chore] [pdata] update comments to make it clear which functions panic #9107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berkeli
commented
Dec 13, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9107 +/- ##
=======================================
Coverage 90.22% 90.22%
=======================================
Files 345 345
Lines 18019 18019
=======================================
Hits 16257 16257
Misses 1433 1433
Partials 329 329 ☔ View full report in Codecov by Sentry. |
TylerHelmuth
approved these changes
Dec 15, 2023
bogdandrutu
approved these changes
Dec 15, 2023
bogdandrutu
reviewed
Dec 15, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
reviewed
Jan 10, 2024
dmitryax
approved these changes
Jan 16, 2024
|
@berkeli can you please resolve the linter failures? |
Apologies, didn't notice failures. Fixed now 🙇 |
dmitryax
approved these changes
Feb 2, 2024
|
Thanks @berkeli! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This updates comments and adds tests based on #9070
Link to tracking Issue: #9070
Testing: This only updates comments, but I have added unit tests to verify the behaviour described in comments