[configtls] support setting cipher suites #9168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9168 +/- ##
==========================================
+ Coverage 90.33% 90.34% +0.01%
==========================================
Files 340 340
Lines 17968 17987 +19
==========================================
+ Hits 16232 16251 +19
Misses 1412 1412
Partials 324 324 ☔ View full report in Codecov by Sentry. |
andrzej-stencel
approved these changes
Dec 27, 2023
dmitryax
approved these changes
Jan 8, 2024
codeboten
approved these changes
Jan 17, 2024
atoulme
force-pushed
the
cipher_suites
branch
from
440b86c
to
4673ff4
Compare
codeboten
reviewed
Jan 17, 2024
Co-authored-by: Alex Boten <[email protected]>
TylerHelmuth
pushed a commit
to TylerHelmuth/opentelemetry-collector
that referenced
this pull request
Jan 23, 2024
**Description:** Add `cipher_suites` to configtls: Users can specify a list of cipher suites to pick from. If left blank, a safe default list is used. **Link to tracking Issue:** Fixes open-telemetry#8105 **Testing:** Unit tests **Documentation:** godoc and README --------- Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
cipher_suitesto configtls:Users can specify a list of cipher suites to pick from. If left blank, a safe default list is used.
Link to tracking Issue:
Fixes #8105
Testing:
Unit tests
Documentation:
godoc and README