-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdatagen] copy files from contrib to core #9172
Conversation
This is to allow us to use it in core as well Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9172 +/- ##
==========================================
- Coverage 91.39% 90.54% -0.86%
==========================================
Files 320 330 +10
Lines 17208 18195 +987
==========================================
+ Hits 15728 16475 +747
- Misses 1177 1383 +206
- Partials 303 337 +34 ☔ View full report in Codecov by Sentry. |
Super happy/excited with this change, and LGTM |
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be at https://github.com/open-telemetry/opentelemetry-go-build-tools instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be at https://github.com/open-telemetry/opentelemetry-go-build-tools instead?
Seems no because of dependency issue. (mdatagen depends on core while core depends on build-tools)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave it here then :) AFAICT the dependency is just on the autogenerated code used for testing, which we could split off into a separate module to avoid a circular module dependency, but no need to do this now
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Follows #9172 Signed-off-by: Alex Boten <[email protected]>
Follows #9172 Signed-off-by: Alex Boten <[email protected]>
This is to allow us to use it in core as well