Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore][CI/CD] Add make gotidy check in build-and-test.yml #9216

Merged
merged 2 commits into from
Jan 5, 2024
Merged

[chore][CI/CD] Add make gotidy check in build-and-test.yml #9216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff7c757
[chore][CI/CD] Add make gotidy check in build-and-test.yml
crobert-1 Jan 3, 2024
42335de
Remove extra line
crobert-1 Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ jobs:
run: make misspell
- name: checkdoc
run: make checkdoc
- name: Check for go mod dependency changes
run: |
make gotidy
git diff --exit-code || (echo 'go.mod/go.sum deps changes detected, please run "make gotidy" and commit the changes in this PR.' && exit 1)
Comment on lines +110 to +113
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeboten @dmitryax did we not have this before?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm as surprised as you are... it looks like gotidy was never added to the workflows in this repo when it was added to the contrib repo open-telemetry/opentelemetry-collector-contrib@d67d622

- name: go:porto
run: |
make goporto
Expand Down
Loading