match spans on resource attributes

[zeitlinger]

match spans on resource attributes

Use case: drop attribute values (e.g. a password) for a certain version (host.image.version)

allow regexp when matching attribute value if it is a string

Regular expressions should only be prohibited if the expected value is not a string (because an implicit conversion to string would be unexpected).
If the expected value is a string, then a regular expression should be allowed.

Note:

This is a prototype to discuss the feature.

More tests, example config, and documentation will be added later.

[ehmke]

Hey, why was this closed in favor of the RewritableTracer? One could argue that it is more efficient to leave the logic to drop sensitive attributes in here after sampling the traces, instead of redacting every single span in the RewritableTracer...

[zeitlinger]

Hey, why was this closed in favor of the RewritableTracer? One could argue that it is more efficient to leave the logic to drop sensitive attributes in here after sampling the traces, instead of redacting every single span in the RewritableTracer...

1. RewritableTracer was closed, not this PR
2. This PR is in draft mode, because it depends on Match spans against the instrumentation library and resource attributes #928
3. RewritableTracer is doing the same thing - it provided no additional benefit to the already existing spans processors (except for this small PR)
4. The span processor can either run in the collector or as an agent in the application process, so the order of sampling and redacting should be a matter of configuration

[tigrannajaryan]

@zeitlinger do you intend to continue working on this draft PR?

[zeitlinger]

@tigrannajaryan it's still pending the coutcome of #928 - but since this isn't moving - I'm going to separate the 2 PRs now.

[codecov]

Codecov Report

Merging #929 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
+ Coverage   92.03%   92.06%   +0.03%     
==========================================
  Files         259      259              
  Lines       17584    17605      +21     
==========================================
+ Hits        16183    16208      +25     
+ Misses        992      990       -2     
+ Partials      409      407       -2     

Impacted Files	Coverage Δ
...rnal/processor/filterset/strict/strictfilterset.go	100.00% <ø> (ø)
processor/metrics.go	71.11% <ø> (-2.09%)	⬇️
internal/processor/filterspan/filterspan.go	100.00% <100.00%> (+6.06%)	⬆️
processor/attributesprocessor/attributes.go	92.00% <100.00%> (-2.12%)	⬇️
processor/spanprocessor/span.go	89.13% <100.00%> (-0.97%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0896e...044f5a4. Read the comment docs.

[zeitlinger]

@tigrannajaryan it's still pending the coutcome of #928 - but since this isn't moving - I'm going to separate the 2 PRs now.

this is finished, please give your feedback.

Also see the discussion in #928 (comment)

[bogdandrutu]

@zeitlinger please rebase, I will review after :). Sorry for the delay.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Gregor Zeitlinger (7f03f77)

[zeitlinger]

@zeitlinger please rebase, I will review after :). Sorry for the delay.

np, also took me a while after all the refactorings in this area.

[tigrannajaryan]

@zeitlinger do you plan to continue working on this PR (it shows as "draft" now)?

[zeitlinger]

The idea was to collect feedback and then add more documentation. I'll remove the draft status, as it caused confusion.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.