Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update grpc instrumentation #9312

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

codeboten
Copy link
Contributor

Potentially fix #9296

Potentially fix open-telemetry#9296

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested review from a team and Aneurysm9 January 18, 2024 15:57
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1599fe) 90.36% compared to head (eb38c58) 90.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9312   +/-   ##
=======================================
  Coverage   90.36%   90.36%           
=======================================
  Files         340      340           
  Lines       17987    17987           
=======================================
  Hits        16254    16254           
  Misses       1410     1410           
  Partials      323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten
Copy link
Contributor Author

Looks like the next release of the dependencies is close, will wait until that's available and update this PR

Alex Boten added 2 commits January 18, 2024 08:27
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten merged commit 8131d31 into open-telemetry:main Jan 18, 2024
32 checks passed
@codeboten codeboten deleted the codeboten/fix-grpc-crash branch January 18, 2024 17:21
@github-actions github-actions bot added this to the next release milestone Jan 18, 2024
TylerHelmuth pushed a commit to TylerHelmuth/opentelemetry-collector that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants